Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spsh 59 #37

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Spsh 59 #37

merged 6 commits into from
Oct 16, 2023

Conversation

DPDS93CT
Copy link
Contributor

@DPDS93CT DPDS93CT commented Oct 10, 2023

Description

Links to Tickets or other pull requests

Changes

New API for frontend to provide endpoint(s) for login.
Endpoint is available in two variants as of now, following can be returned:
/login => returns Promise (for current usage in frontend)
/login/result => returns Promise<Result<string, DomainError>> (for future use in frontend)
New exception class 'UserAuthenticationFailedError'

Deployment

New Repos, NPM pakages or vendor scripts

added packages: openid-client for keycloak functionality, express for usage of response and request in exceptions-filters of NestJS

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

@jaggarnaut
Copy link
Contributor

Lokal kann ich keine Requests an das Backend ausführen, wenn nicht in src/server/main.ts in Z21 folgendes steht:
app.enableCors();

Könnt ihr das bitte hinzufügen oder eine Alternative prüfen?

@kristoff-kiefer
Copy link
Contributor

kristoff-kiefer commented Oct 10, 2023 via email

@jaggarnaut
Copy link
Contributor

jaggarnaut commented Oct 12, 2023

Hallo Julian, ich möchte die CORS-Protection nicht ausmachen. Kannst du dir mal https://vitejs.dev/config/server-options.html#server-proxy anschauen, damit kannst du lokal das Backend die gleiche Adresse ausliefern wie deine Seiten. Das sollte das Problem fixen. @Tegtmeyer, Cornelius @.***> Kannst du zur Not supporten? Danke Kristoff

Mit dem dev Proxy hat es geklappt, danke.

src/modules/ui-backend/domain/login.service.ts Outdated Show resolved Hide resolved
config/config.test.json Outdated Show resolved Hide resolved
@kristoff-kiefer kristoff-kiefer merged commit 2d94222 into main Oct 16, 2023
7 checks passed
@kristoff-kiefer kristoff-kiefer deleted the SPSH-59 branch October 16, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants